Fix crash when trying to kill a finished NativeAppJob

Authored by croick on Jun 21 2017, 5:34 PM.

Description

Fix crash when trying to kill a finished NativeAppJob

Summary:

  • when starting the same job twice, a dialog pops up, asking whether to kill the running job
  • if the job finished meanwhile, the running job instance ceases to exist and accessing its member causes a crash
  • probably the same as Bug 364317

Solution:

  • add a check for existence of the job after the dialog

BUG: 364317
FIXED-IN: 5.1.2

Test Plan:

  • start the same job twice (a unit test for instance)
  • click on "Yes" (do kill the running job), if the dialog pops up, after the job finished

Reviewers: KDevelop, apol

Reviewed By: KDevelop, apol

Subscribers: apol, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D6286

Details

Committed
kfunkJun 21 2017, 5:35 PM
Reviewer
KDevelop
Differential Revision
D6286: Fix crash when trying to kill a finished NativeAppJob
Parents
R33:96412460b6c7: Prefer QDir::tempPath() over "/tmp"
Branches
Unknown
Tags
Unknown