Differential D6279

API dox: add notes to KActionCollection about QAction ownership handling
ClosedPublic
Actions

Authored by kossebau on Jun 19 2017, 5:59 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R263:951bc8a9b3c9: API dox: add notes to KActionCollection about QAction ownership handling

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jun 19 2017, 5:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 19 2017, 5:59 PM
apol added a subscriber: apol.Jun 19 2017, 6:31 PM

Then it would make sense to say what happens if an action is destroyed as well, no?
Something like If an action is destroyed will be removed automatically from the KActionCollection. Which is what I think it happens but didn't really check.

kossebau updated this revision to Diff 15611.Jun 19 2017, 10:44 PM

note auto-removal on destroying the action

dfaure accepted this revision.Jun 20 2017, 7:22 AM
dfaure added inline comments.
src/kactioncollection.h
325 ↗(On Diff #15611)

I would add a newline after the '.'
Otherwise it looks like the second sentence is related to the first, but it's not really.

341 ↗(On Diff #15611)

same

This revision is now accepted and ready to land.Jun 20 2017, 7:22 AM
Closed by commit R263:951bc8a9b3c9: API dox: add notes to KActionCollection about QAction ownership handling (authored by kossebau). · Explain WhyJun 20 2017, 10:35 AM
This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.

Revision Contents
Changeset List

PathPackages
Msrc/kactioncollection.h (17 lines)

Diff 15637

View Options

src/kactioncollection.h

Loading...