Fix switch desktop through edge when moving window
ClosedPublic
Actions

Authored by graesslin on Jun 18 2017, 11:39 AM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:c45e165514ec: Fix switch desktop through edge when moving window

Summary

There was a regression introduced in ScreenEdges when introducing the
activatesForPointer method. It considered the switch desktop on edge,
but not the special case of switch desktop when moving windows. Due to
that the edges did not activate when moving the window.

This change addresses the regression and extends the autotest to ensure
it's properly covered.

BUG: 380440
FIXED-IN: 5.10.3

Test Plan

Manual testing and extended auto test

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Jun 18 2017, 11:39 AM

Restricted Application added a project: KWin. · View Herald TranscriptJun 18 2017, 11:39 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

broulik accepted this revision.Jun 18 2017, 12:50 PM

This revision is now accepted and ready to land.Jun 18 2017, 12:50 PM

graesslin added a dependent revision: D6264: Fix switch desktop on screenedge while resizing a Wayland window.Jun 19 2017, 5:09 AM

Closed by commit R108:c45e165514ec: Fix switch desktop through edge when moving window (authored by graesslin). · Explain WhyJun 20 2017, 5:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/mock_abstract_client.h (3 lines)
M			autotests/mock_abstract_client.cpp (11 lines)
M			autotests/mock_client.h (2 lines)
M			autotests/mock_client.cpp (5 lines)
M			autotests/test_screen_edges.cpp (21 lines)
M			screenedge.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15543	cfe13c5		Jun 18 2017, 11:39 AM	★	★
Diff 2	15616	a6dee74	R108:c45e165514ec70314d721d6e0238431ab92bd441	Jun 20 2017, 4:57 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
5f744f1fc5a1	10446803983c	cfe13c5a4ff7	Martin Flöser	Fix switch desktop through edge when moving window (Show More…)	Jun 18 2017, 11:36 AM

	Status	Author	Revision
	Closed	graesslin	D6264 Fix switch desktop on screenedge while resizing a Wayland window
	Closed	graesslin	D6257 Fix switch desktop through edge when moving window