Without this patch, we occasionally end up in a situation where the DesktopIcon object is deleted while we are still fetching data from the network, resulting in attempting to access member variables which have since been deleted.
Details
Details
- Reviewers
mart apol davidedmundson - Group Reviewers
Kirigami - Commits
- R169:f3f2622e79b9: Don't crash when deleted during network operations
This can be provoked in Discover by scrolling through a long list of KNS items (such as the Plasma -> Wallpapers section) using the scrollbar. Simply scroll up and down rapidly, and a crash will occur with high regularity (within a matter of a second or two). With this patch, the crash is entirely eliminated.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/desktopicon.cpp | ||
|---|---|---|
| 333 | Normal convention for handling nested event loops (which is effectively what this is) is making a QPointer of "this" and checking that | |