Expose and use Engine's page size variable

Authored by leinir on Jun 12 2017, 12:40 PM.



Engine has a pageSize variable which has been mostly unused, but which comes in very handy when getting large sets of data. This patch exposes that variable through a setter, and makes use of it internally whenever a request is made (so the page size is actually honoured the way it seems to have been intended)

Diff Detail

R304 KNewStuff
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Jun 12 2017, 12:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 12 2017, 12:40 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol added a subscriber: apol.Jun 12 2017, 1:12 PM

I have no idea about the patch itself, why it wasn't exposed so far that is.


I wouldn't pass an int as const&

As far as i can gather, it was simply never added because, well, it was never used in a lot of places... This really is more a case of equalising some features between requestData and other parts of the engine (so they can all be paginated by the size they really want to be).


No, quite true - force of habit and all that :)

leinir updated this revision to Diff 15377.Jun 12 2017, 1:25 PM

Don't const & an int, that's just silly.

apol accepted this revision.Jun 12 2017, 4:57 PM

It all makes sense, so good from my side.

This revision is now accepted and ready to land.Jun 12 2017, 4:57 PM
This revision was automatically updated to reflect the committed changes.