Engine has a pageSize variable which has been mostly unused, but which comes in very handy when getting large sets of data. This patch exposes that variable through a setter, and makes use of it internally whenever a request is made (so the page size is actually honoured the way it seems to have been intended)
Details
Details
- Reviewers
apol - Group Reviewers
KNewStuff - Commits
- R304:2f8580b9e604: Expose and use Engine's page size variable
Diff Detail
Diff Detail
- Repository
- R304 KNewStuff
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I have no idea about the patch itself, why it wasn't exposed so far that is.
| src/core/engine.cpp | ||
|---|---|---|
| 144 | I wouldn't pass an int as const& | |
Comment Actions
As far as i can gather, it was simply never added because, well, it was never used in a lot of places... This really is more a case of equalising some features between requestData and other parts of the engine (so they can all be paginated by the size they really want to be).
| src/core/engine.cpp | ||
|---|---|---|
| 144 | No, quite true - force of habit and all that :) | |