Differential D6143

Even on plasma we shouldn't be using plasma icons
ClosedPublic
Actions

Authored by apol on Jun 7 2017, 8:56 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:f4863c518792: Even on plasma we shouldn't be using plasma icons
Summary

We want to use the icons for applications rather than for the shell. It should
work well with the applications color theme rather than the shell's.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Jun 7 2017, 8:56 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 7 2017, 8:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Jun 7 2017, 9:00 PM

Why would it be using the Plasma theme then?

apol added a comment.Jun 7 2017, 9:40 PM
In D6143#114962, @davidedmundson wrote:

Why would it be using the Plasma theme then?

Kirigami shouldn't AFAIU, that's why I'm setting it to false.
Am I lost in translation?

davidedmundson added a comment.Jun 7 2017, 9:44 PM

I mean, if we're an application, we should be only using things loaded from src/styles/org.kde.desktop
and not files in src/styles/Plasma

mart accepted this revision.Jun 9 2017, 10:58 AM

it may make sense...
all depends from what we decide to do in plasma mobile, that would be pretty much the place where this is used
restricting icons to system theme may make things simpler to understand for developers

This revision is now accepted and ready to land.Jun 9 2017, 10:58 AM
apol added a comment.Jun 9 2017, 11:06 AM
In D6143#115262, @mart wrote:

it may make sense...
all depends from what we decide to do in plasma mobile, that would be pretty much the place where this is used.

Why would we do something different on Plasma Mobile?

restricting icons to system theme may make things simpler to understand for developers

+1

apol closed this revision.Jun 9 2017, 11:07 AM

Revision Contents
Changeset List

PathPackages
Msrc/styles/Plasma/Icon.qml (1 line)

Diff 15264

View Options

src/styles/Plasma/Icon.qml

Loading...