I hate having to look up when interesting new classes were added.
Patch is straight-forward (I think), but:
- should @since be added on all memebers, when it's already on the class?
- would simple patches such as this be ok to commit without review?
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R216:e48e34bd0288: Add since tags.
Diff Detail
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The patch is simple, but it is always a good idea to ask for a review.
Since this frameworks is new as of 5.28, should we really mark each class this way? We did not do this for other "new" frameworks, such as prison or kwayland.
Comment Actions
You mean, if I'm not sure whether the framework exists, I should just test for it in cmake. Arguably true, but to an application developer, it is important to be able to pin down when I can reasonably expect something to be available on my target platforms. Without having to resort to code archeology.
Qt marks version of appearance for classes in "new" modules such as QWebEngine, too. Too bad, if we don't do this consistently (yet), but I cannot see how it could possibly be "better" not to.
Comment Actions
Excellent idea. I would say, we should have done the same in other new frameworks. If we treat KF5 as a whole, then these classes are simply "new since 5.28" in a bigger "package" that already existed (KF5).