Differential D6078

Fix hang on a lot of output from a program
ClosedPublic
Actions

Authored by sandsmark on Jun 3 2017, 5:59 PM.

Details

Reviewers
thiago
Group Reviewers
Konsole
Commits
R319:ac59cc7e007a: Fix hang on a lot of output from a program
Summary
There is a bug in the Qt glib event loop leading to timers never being
able to deliver signals.

Work around this by disabling the glib event loop.

References:
http://lists.qt-project.org/pipermail/interest/2015-September/018846.html
https://bugreports.qt.io/browse/QTBUG-48344

CCBUG: 230184

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark created this revision.Jun 3 2017, 5:59 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 3 2017, 5:59 PM
hindenburg added a subscriber: hindenburg.Jun 4 2017, 2:30 PM

Is https://bugs.kde.org/show_bug.cgi?id=372991 a different issue? This patch doesn't appear to fix that as I can still reproduce it.

hindenburg added a comment.Oct 25 2017, 1:03 PM

OK, I don't think I've run into this before - if you feel this is the correct fix, since Qt fix doesn't appear to be going anywhere), go ahead.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 16 2018, 11:49 AM
Closed by commit R319:ac59cc7e007a: Fix hang on a lot of output from a program (authored by sandsmark). · Explain Why
This revision was automatically updated to reflect the committed changes.
Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptJul 16 2018, 11:49 AM

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (8 lines)
AMtests/spam-stderr.c (15 lines)

Diff 37868

View Options

src/main.cpp

Loading...
View Options

tests/spam-stderr.c

Loading...