Move search line upper bound check to less generic function
fcea6742c142
Actions

Authored by mglb on Jul 14 2018, 12:34 AM.

Description

Move search line upper bound check to less generic function

Summary:
When there was at least one search attempt, search box is still opened,
and the screen and/or history is cleared, there is a high chance that
the line number remembered by the search is invalid. The line number is
used as the lines array index, so this can lead to overflow and crash.

This is at this moment fixed with a check in copyLineToStream(), which
is a generic function that happens to be used by search function and
where the line number is used. There still is an assert which is
triggered in debug builds.

The patch moves the check directly to a search function, where the line
number is initialized before first search.

Test Plan:
You have to do the test in debug build - there is a hack in
copyLineToStream() which prevents crash, but assert before it
catches an error condition.