Differential D6073

Don't enable strict iterators on MSVC
AbandonedPublic
Actions

Authored by bcooksley on Jun 3 2017, 9:55 AM.

Details

Reviewers
kfunk
Summary

Currently we've found that strict iterators as available in MSVC, with certain codebases such as Threadweaver cause breakages to show up within Qt itself (in 5.7 at least).

See https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsQt5.7/4/consoleText for the build log.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Lint Skipped
Unit
Unit Tests Skipped
bcooksley created this revision.Jun 3 2017, 9:55 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJun 3 2017, 9:55 AM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
kfunk requested changes to this revision.Jun 5 2017, 11:48 AM
kfunk added subscribers: arrowd, kfunk.

I don't think we should do that. Compilation only breaks on MSVC2017, which is fairly new. And according to some test compilations by @arrowdodger, this seems to be the only location where we hit that compiler(?) bug when compiling all of KF5.

Let's just work-around/rewrite this single code path. An other (less ideal) solution is to disable strict iterators for MSVC2017 only.

This revision now requires changes to proceed.Jun 5 2017, 11:48 AM
bcooksley abandoned this revision.Jun 8 2017, 9:14 AM

Revision Contents
Changeset List

Diff 15105

View Options

kde-modules/KDEFrameworkCompilerSettings.cmake

Loading...