It's more efficient, especially in memory
Details
Details
- Reviewers
leinir - Group Reviewers
Frameworks - Commits
- R304:00aa6b29644b: Make it possible to use QXmlStreamReader to read a KNS registry file
tests pass, discover kns test passes, discover works
Diff Detail
Diff Detail
- Repository
- R304 KNewStuff
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/core/entryinternal.cpp | ||
|---|---|---|
| 443 ↗ | (On Diff #15096) | missing spaces around == |
| 446 ↗ | (On Diff #15096) | same |
| 450 ↗ | (On Diff #15096) | same |
| 527 ↗ | (On Diff #15096) | Did you test parsing a file with <!-- ... --> comments here and there? Just to make sure the code handles this correctly and doesn't assert. |
| src/core/entryinternal.h | ||
| 391 ↗ | (On Diff #15096) | "@deprecated since 5.36, use setEntryXML(QXmlStreamReader&) instead" |
Comment Actions
On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained backwards compatibility). From what i can tell, this would assert when an unknown tag is encountered, right?
Comment Actions
This is for .knsregistry files, not OCS. These files are generated by the very same class here.
Comment Actions
You are quite right, i forgot the attica content's not parsed using knscore's functions, just the staticxml provider... because i'm a silly person :) Obviously just fine, then, go for it!