Ported away some classes, removes many unneeded casts that happen when starting.
Details
Details
- Reviewers
mart - Group Reviewers
Frameworks Plasma - Commits
- R242:563011436d5f: Port a bunch of classes away from Plasma::Package
Tests still pass, plasma starts properly
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/plasma/pluginloader.h | ||
|---|---|---|
| 208 | wow, phab isn't that smart in the diff it makes checking for binary compatibility quite tricky ;) | |
| src/plasmaquick/appletquickitem.h | ||
| 105–106 | despite the warning in the header, this ended up being an exported symbol, so binary compatibility rules apply here too. | |
| src/scriptengines/qml/plasmoid/wallpaperinterface.h | ||
| 26 | why plasma_export.h? | |
| src/plasmaquick/appletquickitem.h | ||
|---|---|---|
| 105–106 | Okay, will fix in a next patch. Please note nobody is using these methods and we could possibly scrap altogether the storing of appletPackage and coronaPackage. | |
Comment Actions
Can we wait till after the next release is tagged as that's super soon and this isn't that important.
We've had major bugs porting stuff in this area before.