Differential D6012

Add asserts to some TokenStreamBase methods, protect against out-of-bounds
ClosedPublic
Actions

Authored by kossebau on May 29 2017, 2:45 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R51:e45aa7b0fbb3: Add asserts to some TokenStreamBase methods, protect against out-of-bounds
Summary

ASAN-enabled tests on KDE CI show out-of-bounds access issues at least
with kdev-css, so better have this fail for developers with normal
debug builds as well.

Diff Detail

Repository
R51 KDevelop: PG Qt
Branch
addasserts
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.May 29 2017, 2:45 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 29 2017, 2:45 PM
kfunk accepted this revision.May 29 2017, 3:15 PM
kfunk added a subscriber: kfunk.

+1, but please add the other asserts, too

include/kdev-pg-token-stream.h
199

assert non-empty?

207

dito

This revision is now accepted and ready to land.May 29 2017, 3:15 PM
Closed by commit R51:e45aa7b0fbb3: Add asserts to some TokenStreamBase methods, protect against out-of-bounds (authored by kossebau). · Explain WhyMay 29 2017, 3:33 PM
This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.May 29 2017, 3:34 PM

Revision Contents
Changeset List

PathPackages
Minclude/kdev-pg-token-stream.h (4 lines)

Diff 14937

View Options

include/kdev-pg-token-stream.h

Loading...