| aacid |
On Windows, even if we have bash (which is provided , for example, by the GoW project) we don't have the tools required by validate-svg.sh to actually run. We'd need to also ensure the unixy 'find' command (not the Windows 'find' command) as well as xmllint.
For now let's not even bother on Windows.
A better solution is to write a new portable script in Python . and also you need to make sure xmllint is available.
| Lint Skipped |
| Unit Tests Skipped |
I don't understand, you say it has bash, so why are you commenting out the bash related code?
Because Hannah told me the script doesn't work on Windows.
let's look at validate-svg.sh.
you need a working unix 'find' command (not the WIndows find command) as well as xmllint for the bash script to work.
Then you need a better commit message :)
Saying "we have bash, let's comment this bash using script" is not what you're doing. What you're doing is "we don't have the tool required by this bash script even if we do actually have bash"
You want the impossible to remember
Differential Revision: https://phabricator.kde.org/D<number>
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages