Implement the new panel icon size ceiling also for Input Method Panel.
AbandonedPublic

Authored by hein on May 23 2017, 11:44 PM.

Details

Reviewers
xuetianweng
mart
broulik
Group Reviewers
Plasma
Summary

It was done for various other applets but not this.

BUG:378443

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.10
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.May 23 2017, 11:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2017, 11:44 PM
hein added a comment.May 23 2017, 11:48 PM

This is a good first start but creates some new problems due to the convoluted layout code in the applet: When the panel is really small and forces things to be smaller than the preferred size, the icons shrink further but the spacing between them doesn't adjjust anymore.

Weng please finish this patch for me since you know your code better. Basically, the goal is that in a panel, the icons don't grow beyond System Settings -> Icons -> Advanced -> Panel -> Size as we've implemented elsewhere for 5.10.

We tag 5.10 on Thursday so there's not much time if we want kimpanel to behave well.

For 5.11/12 we should finally look into fixing all of this - instead of being a standalone applet kimpanel should create SNIs for every Status Icon that go into the system tray, and have a suitable distinct category so we can sort them correctly in the tray layout. Then hiding can be done via the tray settings etc etc.

hein abandoned this revision.EditedMay 24 2017, 5:50 PM