Differential D5947

Allow write access to Samba Shares' root
ClosedPublic
Actions

Authored by madcatx on May 23 2017, 8:37 PM.

Details

Reviewers
elvisangelaccio
Commits
R320:550e6915b4a3: Allow write access to Samba Shares' root
Summary

kio_smb plugin sets Samba Shares as read-only which results in incorrect behavior when a user tries to write into a share. This is a partial fix of https://bugs.kde.org/show_bug.cgi?id=376344

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
madcatx created this revision.May 23 2017, 8:37 PM
elvisangelaccio accepted this revision.Jul 6 2017, 10:04 AM

Sorry for the delay. I don't use samba but this patch makes sense.

This revision is now accepted and ready to land.Jul 6 2017, 10:04 AM
broulik added a subscriber: broulik.Jul 8 2017, 11:11 AM

Do you have commit access? Otherwise I can push this on your behalf so it doesn't get lost. Thanks.

madcatx added a comment.Jul 8 2017, 11:18 AM
In D5947#122926, @broulik wrote:

Do you have commit access? Otherwise I can push this on your behalf so it doesn't get lost. Thanks.

I myself cannot commit anything, I'd be great if you could push it, thanks.

elvisangelaccio added a comment.Jul 10 2017, 5:09 PM

@madcatx What's your email (for the commit message)? The one you use in bugs.kde.org?

madcatx added a comment.Jul 10 2017, 5:26 PM

I'd rather commit under my primary phabricator email if you can view it.

elvisangelaccio added a comment.Jul 10 2017, 5:29 PM

Nope, phabricator doesn't show it as far as I can see.

madcatx added a comment.Jul 10 2017, 5:30 PM
This comment was removed by madcatx.
Closed by commit R320:550e6915b4a3: Allow write access to Samba Shares' root (authored by madcatx, committed by elvisangelaccio). · Explain WhyJul 10 2017, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmb/kio_smb_browse.cpp (8 lines)

Diff 16460

View Options

smb/kio_smb_browse.cpp

Loading...