Code refactoring, commening, and implement enough to have kdeconnect show as an option when adding an account!
ClosedPublic
Actions

Authored by sredman on May 23 2017, 4:32 AM.

Details

Reviewers

kdeconnect
davidedmundson
apol

Commits

R716:ecfa4757d6b6: Code refactoring, commening, and implement enough to have kdeconnect show as an…

Summary

Add header comments to Presence emthods

Add header comment to curious 'messageReceived' signal

Add header comment to ConnectConnectoin::receiveMessage

Add header comments to Presence emthods

Add header comment to curious 'messageReceived' signal

Add .arcconfig

Add more header comments, including to file header

Remove ability to add contacts via telepathy plugin

Adding a contact in the desktop has the assumption that this contact will appear on the phone. I would like to make sure this assumption doesn't hold by having the plugin report that the contacts book is non-modifiable

Move enabling warnings and debug to main.cpp

Add protocol specifications to manager file

Add protocol definitions to protocol implementation

Begin the long journey of removing kdeconnecttelepathyprotocolfactory, as it is probably unneeded once the account adding is properly set up

Add required 'device_id' parameter to hacked-in account

Add dummy profile file

Officially change name from connectcm to telepathy-kdeconnect

Reenable the ability to set account online and offline manually (even though it's currently meaningless)

Remove duplicate parameter from .manager file

Diff Detail

Repository

R716 Telepathy KDE Connect Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sredman created this revision.May 23 2017, 4:32 AM

sredman added a reviewer: kdeconnect.May 23 2017, 4:36 AM

Other than that, LGTM.
I'm not all that into telepathy connection managers though.

CMakeLists.txt
16	Ugh no, don't do that. Rename it if you want, but don't pass the name with a variable. Better be explicit.
connection.cpp
175	You added one comment in the cpp and the other on the header. Please do the same on both.

albertvaka added a reviewer: davidedmundson.May 23 2017, 8:04 PM

Code refactoring, commening, and implement enough to have kdeconnect show as an option when adding an account!

sredman marked an inline comment as done.May 24 2017, 1:32 AM

sredman added inline comments.

CMakeLists.txt
16	Thank you for the feedback! I have never used CMake before, so I have not seen the failure case using a variable for the outputs would cause. Do you have a horror story (which you would like to share), or is this just general good practice?
connection.cpp
175	Do you mean I should have, for method-header comments, the same thing in both the .h and .cpp files? The reason I don't want to do this (at least not at present) is that everything is changing quite rapidly. It would be hard to keep the two sets of comments in sync (and they would surely get out of sync) To that end, I have been keeping all my header comments in the .cpp file. The comment in the .h file for the messageReceived(..) signal is only in the .h file because it doesn't appear in the .cpp In general, I like using something like doxygen to keep track of comments regardless. This solves the problem of wondering whether a header comment belongs in the source or header file, because it is easier and nicer-looking to refer to the doxygen output in any case. I have added a Doxyfile (and the related output to the .gitignore)

apol accepted this revision.May 31 2017, 1:55 PM

This revision is now accepted and ready to land.May 31 2017, 1:55 PM

Closed by commit R716:ecfa4757d6b6: Code refactoring, commening, and implement enough to have kdeconnect show as an… (authored by sredman, committed by albertvaka). · Explain WhyJun 1 2017, 9:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		.gitignore (1 line)
M		CMakeLists.txt (18 lines)
A	M	Doxyfile (2473 lines)
M		connection.cpp (4 lines)
M		kdeconnect.manager (12 lines)
A	M	kdeconnect.profile (27 lines)
M		kdeconnecttelepathyprotocolfactory.cpp (11 lines)
M		main.cpp (5 lines)
M		protocol.h (1 line)
M		protocol.cpp (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14770	ff8979b		May 23 2017, 4:32 AM	★	★
Diff 2	14793	ff8979b	Code refactoring, commening, and implement enough to have kdeconnect show as an…	May 24 2017, 1:29 AM	★	★
Diff 3	15044	ed25c47	R716:ecfa4757d6b6d1ec509755c80a8d13b6ec5f81cf	Jun 1 2017, 9:41 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
b7c8b1d0be7d	950eb521d2a0	ed010432b0e6	Simon Redman	Add Doxyfile and related ignores	May 24 2017, 1:28 AM
ed010432b0e6	8eb3dd06fa5d	ea67abf456b6	Simon Redman	Code refactoring, commening, and implement enough to have kdeconnect show as an… (Show More…)	May 23 2017, 4:31 AM
ea67abf456b6	d1032979346c	d26c273cc240	Simon Redman	Reenable the ability to set account online and offline manually (even though… (Show More…)	May 23 2017, 4:30 AM
d26c273cc240	18bfb64a78fa	d50fd05f7a6e	Simon Redman	Officially change name from connectcm to telepathy-kdeconnect	May 23 2017, 4:30 AM
d50fd05f7a6e	36097e4da920	624f4388a93e	Simon Redman	Add dummy profile file	May 23 2017, 3:28 AM
624f4388a93e	b846c5b2e287	da2073039576	Simon Redman	Add required 'device_id' parameter to hacked-in account	May 23 2017, 3:28 AM
da2073039576	8bfeb4a77eaa	3a6ebb7ef926	Simon Redman	Begin the long journey of removing kdeconnecttelepathyprotocolfactory, as it is… (Show More…)	May 23 2017, 2:16 AM
3a6ebb7ef926	3be09ca5bdfa	027d9532cc1d	Simon Redman	Add protocol definitions to protocol implementation	May 23 2017, 2:16 AM
027d9532cc1d	a52a66b554c1	ccc8ee64d00f	Simon Redman	Add protocol specifications to manager file	May 23 2017, 2:15 AM
ccc8ee64d00f	b8241e07384e	1cd1643e588e	Simon Redman	Move enabling warnings and debug to main.cpp	May 22 2017, 12:04 AM
1cd1643e588e	fb45d673f9c7	e35b54cb914c	Simon Redman	Remove ability to add contacts via telepathy plugin (Show More…)	May 20 2017, 1:22 AM
e35b54cb914c	6de46a48a1a4	b97fadea689a	Simon Redman	Add more header comments, including to file header	May 19 2017, 11:51 PM
b97fadea689a	7903a62f5832	78553d7091f2	Simon Redman	Add header comment to ConnectConnectoin::receiveMessage (Show More…)	May 19 2017, 10:06 PM
78553d7091f2	01a53de8d942	61f451876616	Simon Redman	Add header comment to curious 'messageReceived' signal	May 19 2017, 10:05 PM
61f451876616	681119b211f6	16d32dea01dd	Simon Redman	Add header comments to Presence emthods	May 19 2017, 10:04 PM
16d32dea01dd	daaedabec948	ff8979b81e05	Simon Redman	Add header comment to ConnectConnectoin::receiveMessage	May 19 2017, 10:04 PM