Adding a contact in the desktop has the assumption that this contact will appear on the phone. I would like to make sure this assumption doesn't hold by having the plugin report that the contacts book is non-modifiable
Details
Details
Diff Detail
Diff Detail
- Repository
- R716 Telepathy KDE Connect Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I'm not an expert in KTp, but looks good to me, thanks for caring about the telepathy plugin.
| connection.cpp | ||
|---|---|---|
| 257 | QString()? | |
| connection.cpp | ||
|---|---|---|
| 266 | pstn ? TBH, KTp and others just follow the ConnectionType rather than the status. So it'd be the same as just setting this to available. | |
| connection.cpp | ||
|---|---|---|
| 257 | You're probably right. That error line is just one I copied from a similar method in protocol.cpp. I expect QString() would do exactly the same thing in this context but I don't know -- maybe the author before me intentionally used QLatin1String("") | |
| 266 | Yes, that's what I had in mind. I think the trouble I was having was that pstn isn't in the Telepathy Qt library (That I could find). I haven't dug very far into this, since it's not a big deal for now. | |