Differential D5918

set transientparent for menus
ClosedPublic
Actions

Authored by mart on May 19 2017, 1:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:5ba1bed5823b: set transientparent for menus
Summary

set transient parent for popup menus created by appletinterface/
containmentinterface, it makes them appear at the proper coordinates

Test Plan

containment menus appear where the mouse was pressed

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.May 19 2017, 1:57 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMay 19 2017, 1:57 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.May 19 2017, 5:46 PM
davidedmundson added a subscriber: davidedmundson.

Please test under x.

This revision is now accepted and ready to land.May 19 2017, 5:46 PM
Closed by commit R242:5ba1bed5823b: set transientparent for menus (authored by mart). · Explain WhyMay 22 2017, 8:51 AM
This revision was automatically updated to reflect the committed changes.
mart added a comment.May 22 2017, 8:51 AM
In D5918#110833, @davidedmundson wrote:

Please test under x.

no noticeable difference in x

Revision Contents
Changeset List

Diff 14752

View Options

src/scriptengines/qml/plasmoid/appletinterface.cpp

Loading...
View Options

src/scriptengines/qml/plasmoid/containmentinterface.cpp

Loading...