Fix disabling of Size and Flow sliders
ClosedPublic
Actions

Authored by allenmarshall on May 18 2017, 12:55 AM.

Details

Reviewers

dkazakov
rempt

Group Reviewers

Krita

Summary

Fixes a bug in which, when changing tools or switching between mouse and tablet input, the Size and Flow sliders at the top of the window would become disabled, even if the newly selected tool supports Size and Flow settings.

Test Plan

Open an image in Krita. Select the Line Tool, then the Freehand Brush Tool. On the current master branch, this causes the Size and Flow sliders to become disabled. With the patch, the Size and Flow sliders will stay enabled.

It has been verified that the patch causes no new unit test failures on the author's machine.

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

allenmarshall created this revision.May 18 2017, 12:55 AM

Restricted Application added a subscriber: woltherav. · View Herald TranscriptMay 18 2017, 12:55 AM

allenmarshall mentioned this in D5845: Movable Airbrush Feature.May 18 2017, 1:48 AM

I tested out the patch and it seems like it works well for me. I am not sure if there are some negative side effects that will happen with removing those flags, but I couldn't see any with the testing I did.

I'd have to dig in to figure out why this was written this way... It's pretty old and most of it seems to date back to Silvio Heinrichs involvement.

In any case, Allan, I'd like to invite you to get commit access so you can push your work yourself :-) Please check https://community.kde.org/Infrastructure/Get_a_Developer_Account and cite me as your sponsor.

I tested the patch and it seems to work correctly. Codewise it also looks correct. There is still a small issue with selection tools that inherit from KisToolShape and therefore activate the Size box as well, but it is not a regression, so the patch can be pushed as it is :)

This revision is now accepted and ready to land.May 18 2017, 9:09 AM

Was this already merged to master?

I don't think it was. Should I merge it myself? Is there any particular protocol to follow with merging revisions to master?

Yes, please merge yourself.

There's no special protocol, but it'd be super convenient if you added the following lines to the commit message:

Differential Revision: https://phabricator.kde.org/D5907
BUG:379564

The first one will close this revision, the second will close the related bugreport on bugzilla :)

Okay, next time, add those two lines on a seperate line, it seems it didn't close this like it should... Ah well. *closes*

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/kis_paintop_box.cc (4 lines)
M			libs/ui/tool/kis_tool_freehand.cc (3 lines)
M			libs/ui/tool/kis_tool_shape.cc (3 lines)
M			plugins/tools/basictools/kis_tool_line.h (1 line)
M			plugins/tools/basictools/kis_tool_line.cc (5 lines)