Differential D5893

Missing commit from 2.9, ported to KDb 3
ClosedPublic
Actions

Authored by piggz on May 16 2017, 8:27 PM.

Details

Reviewers
staniek
Maniphest Tasks
T1744: Missing commits to port from calligra.git 2.9
Commits
R71:bc1f88131b36: Missing commit from 2.9, ported to KDb 3
Summary

Unable to test as scripting not yet implemented in Kexi

Test Plan

If it compiles, ship it!

Diff Detail

Repository
R71 Kexi
Branch
missing_script_change
Lint
No Linters Available
Unit
No Unit Test Coverage
piggz created this revision.May 16 2017, 8:27 PM
Restricted Application added a project: KEXI. · View Herald TranscriptMay 16 2017, 8:27 PM
staniek requested changes to this revision.May 16 2017, 8:59 PM

Almost there, thanks Adam!

src/plugins/reports/krscriptfunctions.cpp
34

tableSchema() -> containsTable() == true

39

It won't support query parameters but let's ignore that atm...

This revision now requires changes to proceed.May 16 2017, 8:59 PM
piggz marked 2 inline comments as done.May 16 2017, 9:15 PM
piggz updated this revision to Diff 14614.May 16 2017, 9:17 PM
piggz edited edge metadata.
  • Implement review comment
staniek accepted this revision.May 16 2017, 9:52 PM
This revision is now accepted and ready to land.May 16 2017, 9:52 PM
Closed by commit R71:bc1f88131b36: Missing commit from 2.9, ported to KDb 3 (authored by piggz). · Explain WhyMay 16 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14614

View Options

src/plugins/reports/krscriptfunctions.cpp

Loading...