Differential D589

Added a post incidence removal handler.
AbandonedPublic
Actions

Authored by knauss on Nov 24 2015, 5:36 PM.

Tags

Subscribers

None

Details

Reviewers

mlaurent
smartins
vkrause

Group Reviewers

Maniphest Tasks

T1102: merge kolab kcalcore changes

Commits

R172:979dd1155079: Notify deletion in two steps.

Summary

It needs to provide a pointer to the calendar, because otherwise
that's impossible to find out (the incidence is already removed,
at that point).

Diff Detail

Branch

dev/kolab

Lint

No Linters Available

Unit

No Unit Test Coverage

knauss updated this revision to Diff 1375.Nov 24 2015, 5:36 PM

knauss retitled this revision from to Added a post incidence removal handler..

knauss updated this object.

knauss edited the test plan for this revision. (Show Details)

knauss added reviewers: vkrause, mlaurent, smartins.

knauss added a task: T1102: merge kolab kcalcore changes.

knauss added a reviewer: KDE PIM.Nov 24 2015, 5:44 PM

knauss added a project: KDE PIM.

smartins requested changes to this revision.Nov 24 2015, 10:09 PM

smartins edited edge metadata.

smartins added inline comments.

src/calendar.h
1365	These two functions have the same documentation but different meaning
1429	The concept is good, but the naming is a big clunky notifyIncidenceAboutToBeDeleted() notifyIncidenceDeleted() These match Qt and KDE naming

This revision now requires changes to proceed.Nov 24 2015, 10:09 PM

knauss mentioned this in D588: Notify clients before we actually remove the incidence..Dec 8 2015, 5:20 PM

Renamed delete notify names

commited with 979dd115507926e14e390a1c842f77c81b02fae4

Revision Contents
Changeset List

			Path	Packages
M			src/calendar.h (16 lines)
M			src/calendar.cpp (27 lines)
M			src/memorycalendar.cpp (12 lines)

Diff 1482

src/calendar.h

Loading...

src/calendar.cpp

Loading...

src/memorycalendar.cpp

Loading...