Differential D588

Notify clients before we actually remove the incidence.
AbandonedPublic
Actions

Authored by knauss on Nov 24 2015, 5:35 PM.

Details

Reviewers
mlaurent
smartins
vkrause
Group Reviewers
KDE PIM
Maniphest Tasks
T1102: merge kolab kcalcore changes
Summary

So they still have time to lookup information about i.e. children.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
knauss updated this revision to Diff 1374.Nov 24 2015, 5:35 PM
knauss retitled this revision from to Notify clients before we actually remove the incidence..
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added reviewers: vkrause, mlaurent, smartins.
knauss added a task: T1102: merge kolab kcalcore changes.
knauss added a reviewer: KDE PIM.Nov 24 2015, 5:44 PM
knauss added a project: KDE PIM.
smartins requested changes to this revision.Nov 24 2015, 10:05 PM
smartins edited edge metadata.
smartins added inline comments.
src/memorycalendar.cpp
191

Now the documentation is wrong, since it says it was already deleted, so querying the calendar shouldn't show it.
Adding a new notification, notifyIncidenceAboutToBeDeleted() would be better and consistent with other KDE and Qt APIs

This revision now requires changes to proceed.Nov 24 2015, 10:05 PM
knauss abandoned this revision.Dec 8 2015, 5:20 PM
knauss marked an inline comment as done.

with rename only together with D589 it makes sense, so merging boths

Revision Contents
Changeset List

PathPackages
Msrc/memorycalendar.cpp (9 lines)

Diff 1374

View Options

src/memorycalendar.cpp

Loading...