Fix Enter and Escape keys in tool dialogs (crop, red eye)
ClosedPublic
Actions

Authored by cfeck on May 12 2017, 4:05 PM.

Details

Reviewers

lukas
gateau

Commits

R260:f2a611e0c184: Fix Enter and Escape keys in tool dialogs (crop, red eye)

Summary

When cropping an image, an inline tool dialog bar is added to the view, allowing to accept or reject the current crop region. Users expect the Enter key to accept that dialog, see bug 313806. I also added the Escape key to reject this dialog.

Diff Detail

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cfeck created this revision.May 12 2017, 4:05 PM

gateau requested changes to this revision.May 14 2017, 8:09 PM

gateau added inline comments.

app/viewmainpage.cpp
746	Maybe this could go in AbstractRasterImageViewTool as a `bool onEnterPressed()` method, which would return true if the tool has accepted the Enter key press?
762	Same here with a `bool onEscapePressed()` method

This revision now requires changes to proceed.May 14 2017, 8:09 PM

Just noticed that AbstractRasterImageViewTool already has a keyPressEvent() overload. Would you prefer using this?

Ah yes, using keyPressEvent() sounds like a good idea.

Use the keyPressEvent() of the Tool to handle the Return/Escape keys. This allows each tool to individually decide what to do.

Looks good!

This revision is now accepted and ready to land.Jun 3 2017, 1:56 PM

Closed by commit R260:f2a611e0c184: Fix Enter and Escape keys in tool dialogs (crop, red eye) (authored by cfeck). · Explain WhyJun 4 2017, 12:52 PM

This revision was automatically updated to reflect the committed changes.

muhlenpfordt mentioned this in D9943: Add browse mode action to action collection again.Jan 17 2018, 12:10 PM

muhlenpfordt mentioned this in R260:5bcb8cc92d37: Add browse mode action to action collection again.Jan 22 2018, 9:30 AM

Revision Contents
Changeset List

			Path	Packages
M			app/mainwindow.cpp (1 line)
M			app/viewmainpage.h (3 lines)
M			app/viewmainpage.cpp (40 lines)
M			lib/crop/croptool.h (1 line)
M			lib/crop/croptool.cpp (19 lines)
M			lib/redeyereduction/redeyereductiontool.h (1 line)
M			lib/redeyereduction/redeyereductiontool.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14439			May 12 2017, 3:57 PM	★	★
Diff 2	15029			May 31 2017, 7:31 PM	★	★
Diff 3	15130	f945299	R260:f2a611e0c184dc30b66102c51c3bac71653af224	Jun 4 2017, 12:49 PM	★	★