Support Apple OS X' image/x-icns
ClosedPublic

Authored by kfunk on May 9 2017, 4:38 PM.

Details

Summary

Got added in shared-mime-info 0.20 (2007-02-06). About time.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.May 9 2017, 4:38 PM

Any other places I need to update?

ltoscano accepted this revision.May 10 2017, 8:38 PM
In D5789#108405, @kfunk wrote:

Any other places I need to update?

I don't think so; the association now is valid for both.

It is worth noting that some subformats of icns can't be opened by that Qt plugin (tested trying to find some examples, hit http://www.iconarchive.com/tag/mac-icns), but of course it's not a problem for this review.

I'm fine with master; not sure that it could go to 17.04, though (it fixes gwenview not automatically associated to this file in dolphin, konqueror, etc, but not a critical issue, you can always browse the file from gwenview). Thoughts?

This revision is now accepted and ready to land.May 10 2017, 8:38 PM
kfunk added a comment.May 11 2017, 9:02 AM
In D5789#108405, @kfunk wrote:

Any other places I need to update?

I don't think so; the association now is valid for both.

It is worth noting that some subformats of icns can't be opened by that Qt plugin (tested trying to find some examples, hit http://www.iconarchive.com/tag/mac-icns), but of course it's not a problem for this review.

I'm fine with master; not sure that it could go to 17.04, though (it fixes gwenview not automatically associated to this file in dolphin, konqueror, etc, but not a critical issue, you can always browse the file from gwenview). Thoughts?

Fine with master as well, it's not like this is urgent now... :)

This revision was automatically updated to reflect the committed changes.