Differential D5676

KDE 5 support for kgoldrunner
AbandonedPublic
Actions

Authored by camillodellmour on May 1 2017, 8:18 AM.

Details

Reviewers

ltoscano

Group Reviewers

KDE Games

Summary

Adapted cmake to kde 5
renamed icons to match new icon naming schema
Changed code from kde4 to kde 5 with help from https://community.kde.org/Frameworks/Porting_Notes

Test Plan

Tested on arch linux, but not on windows or mac. Would be important to try this out because there are changes regarding to default directories.

Diff Detail

Repository

R396 KGoldrunner

Lint

Lint Skipped

Unit

Unit Tests Skipped

camillodellmour created this revision.May 1 2017, 8:18 AM

Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMay 1 2017, 8:18 AM

Restricted Application added a subscriber: KDE Games. · View Herald Transcript

There's no such thing as KDE 5, please fix the commit log.

Apart from the non-existing KDE5 (it's a port to KDE Frameworks), there is an almost working "frameworks" branch already. Please discard this review. If you want to help, check this thread where the status of the games was discussed, and join the list and IRC.
https://mail.kde.org/pipermail/kde-games-devel/2017-April/013410.html

This revision now requires changes to proceed.May 1 2017, 9:18 AM

Sorry I did this back in November 2016 but it was somehow lost on github ;-). So if there is already a port to KDE Framworks than this is obsolete.

You are more than welcome to try the frameworks branch and check for issues and regressions, and of course help fixing them! Testing is never enough.

I'll try to rebase this on top of the current frameworks branch, since there is useful stuff in this commit.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (37 lines)
M			doc/CMakeLists.txt (2 lines)
V			src/{128-apps-kgoldrunner.png ← hi128-app-kgoldrunner.png}
V			src/{16-apps-kgoldrunner.png ← hi16-app-kgoldrunner.png}
V			src/{22-apps-kgoldrunner.png ← hi22-app-kgoldrunner.png}
V			src/{32-apps-kgoldrunner.png ← hi32-app-kgoldrunner.png}
V			src/{48-apps-kgoldrunner.png ← hi48-app-kgoldrunner.png}
V			src/{64-apps-kgoldrunner.png ← hi64-app-kgoldrunner.png}
M			src/CMakeLists.txt (22 lines)
V			src/{hi128-app-kgoldrunner.png → 128-apps-kgoldrunner.png}
V			src/{hi16-app-kgoldrunner.png → 16-apps-kgoldrunner.png}
V			src/{hi22-app-kgoldrunner.png → 22-apps-kgoldrunner.png}
V			src/{hi32-app-kgoldrunner.png → 32-apps-kgoldrunner.png}
V			src/{hi48-app-kgoldrunner.png → 48-apps-kgoldrunner.png}
V			src/{hi64-app-kgoldrunner.png → 64-apps-kgoldrunner.png}
M			src/kgoldrunner.h (20 lines)
M			src/kgoldrunner.cpp (138 lines)
M			src/kgrdebug.h (10 lines)
M			src/kgrdialog.h (10 lines)
M			src/kgrdialog.cpp (104 lines)
M			src/kgreditor.cpp (8 lines)
M			src/kgrgame.h (4 lines)
M			src/kgrgame.cpp (201 lines)
M			src/kgrgameio.cpp (28 lines)
M			src/kgrlevelplayer.h (2 lines)
M			src/kgrlevelplayer.cpp (8 lines)
M			src/kgrrenderer.h (2 lines)
M			src/kgrrenderer.cpp (7 lines)
M			src/kgrrulebook.h (2 lines)
M			src/kgrrunner.cpp (26 lines)
M			src/kgrscene.h (2 lines)
M			src/kgrscene.cpp (2 lines)
M			src/kgrselector.h (9 lines)
M			src/kgrselector.cpp (54 lines)
M			src/kgrsounds.cpp (4 lines)
M			src/kgrsprite.cpp (6 lines)
M			src/kgrtimer.cpp (2 lines)
M			src/main.cpp (66 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14045			May 1 2017, 8:07 AM	★	★

KDE 5 support for kgoldrunnerAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 14045

CMakeLists.txt

doc/CMakeLists.txt

src/128-apps-kgoldrunner.png

src/16-apps-kgoldrunner.png

src/22-apps-kgoldrunner.png

src/32-apps-kgoldrunner.png

src/48-apps-kgoldrunner.png

src/64-apps-kgoldrunner.png

src/CMakeLists.txt

src/hi128-app-kgoldrunner.png

src/hi16-app-kgoldrunner.png

src/hi22-app-kgoldrunner.png

src/hi32-app-kgoldrunner.png

src/hi48-app-kgoldrunner.png

src/hi64-app-kgoldrunner.png

src/kgoldrunner.h

src/kgoldrunner.cpp

src/kgrdebug.h

src/kgrdialog.h

src/kgrdialog.cpp

src/kgreditor.cpp

src/kgrgame.h

src/kgrgame.cpp

src/kgrgameio.cpp

src/kgrlevelplayer.h

src/kgrlevelplayer.cpp

src/kgrrenderer.h

src/kgrrenderer.cpp

src/kgrrulebook.h

src/kgrrunner.cpp

src/kgrscene.h

src/kgrscene.cpp

src/kgrselector.h

src/kgrselector.cpp

src/kgrsounds.cpp

src/kgrsprite.cpp

src/kgrtimer.cpp

src/main.cpp

KDE 5 support for kgoldrunner
AbandonedPublic
Actions

Revision Contents
Changeset List