Cleanup KSudoku::updateShapesList() to remove manual path fiddling.
ClosedPublic
Actions

Authored by ouwerkerk on Apr 30 2017, 3:10 PM.

Details

Reviewers

ltoscano

Group Reviewers

KDE Games

Maniphest Tasks

Commits

Summary

This change resolves Phabricator/Maniphest task T5977.

Test Plan

Compiled & tested I could still generate custom game variant puzzles: Mathdoku 4x4, Killer 9x9.

Also, to confirm the duplicate filtering is redundant I ran ksudoku with a deliberately messed up XDG_DATA_DIRS environment variable:

XDG_DATA_DIRS="$XDG_DATA_DIRS:$PWD/kde-5/share;$PWD/kde-5/share;$PWD/kde-5/share" ./kde-5/bin/ksudoku

(Which still lists each game variant type only once, meaning the filtering was in fact redundant.)

Repository

R417 KSudoku

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE Games. · View Herald Transcript

I think it's safe to skip the contains() check entirely, and I'm tempted to remove it. Did I overlook something?

Removed the contains() check, which I believe to be entirely redundant.

ouwerkerk edited the test plan for this revision. (Show Details)

Working as expected.

This revision is now accepted and ready to land.Apr 30 2017, 3:44 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/gui/ksudoku.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14027	b7670c4		Apr 30 2017, 3:10 PM	★	★
Diff 2	14028	b7670c4	Removed the contains() check, which I believe to be entirely redundant.	Apr 30 2017, 3:18 PM	★	★
Diff 3	14029	b7670c4	R417:52bdce6a0d93b21becad5011ffa27b7a5af617b3	Apr 30 2017, 3:51 PM	★	★