Description

There is some remaining manual fiddling with paths, for which Qt provides perfectly good API already.
Since another part of the code in the same function uses QFileInfo, it would be cleaner and more natural to restructure the list of strings of paths into a list of QFileInfo.

Details

Differential Revisions: D5669: Cleanup KSudoku::updateShapesList() to remove manual path fiddling.

Related Objects

Mentioned In: R417:52bdce6a0d93: Cleanup KSudoku::updateShapesList() to remove manual path fiddling.
D5669: Cleanup KSudoku::updateShapesList() to remove manual path fiddling.

ouwerkerk created this task.Apr 28 2017, 4:28 PM

ouwerkerk renamed this task from Cleanup: use QFileInfoList in KSudoku::updateShapesList() to Sudoku: use QFileInfoList in KSudoku::updateShapesList() .Apr 28 2017, 4:40 PM

Working on a Differential for this right now.

ouwerkerk added a revision: D5669: Cleanup KSudoku::updateShapesList() to remove manual path fiddling..Apr 30 2017, 3:10 PM

ouwerkerk mentioned this in D5669: Cleanup KSudoku::updateShapesList() to remove manual path fiddling..

ouwerkerk mentioned this in R417:52bdce6a0d93: Cleanup KSudoku::updateShapesList() to remove manual path fiddling..Apr 30 2017, 3:51 PM

This change has landed.

Sudoku: use QFileInfoList in KSudoku::updateShapesList() Closed, ResolvedPublicActions

Description

Details

Related Objects

Sudoku: use QFileInfoList in KSudoku::updateShapesList()
Closed, ResolvedPublic
Actions