Remove the backup function
AbandonedPublic

Authored by wojnilowicz on Apr 29 2017, 3:23 PM.

Details

Reviewers
christiand
Group Reviewers
KMyMoney
Summary

Backups should be done by third party apps. Removing this function also removes the need to port it to KF5.

Not only the functions were removed but also the action, connects and the config update script will even remove the remaining settings from the config file "kmymoneyrc" on the user's system.

Test Plan

Started KMyMoney and had a look at the menu.
Checked if there are any complains about failed connections in the command line.

Diff Detail

Repository
R261 KMyMoney
Lint
Lint Skipped
Unit
Unit Tests Skipped
christiand created this revision.Apr 29 2017, 3:23 PM
christiand edited the summary of this revision. (Show Details)

I don't like this idea. In the moment there is no third part app to backup KMM, so there will be no backup feature at all.
Moreover I don't get why it must be third part app and not KMM.

I don't like this idea. In the moment there is no third part app to backup KMM, so there will be no backup feature at all.
Moreover I don't get why it must be third part app and not KMM.

Any backup software can be used because it is only needed to save a single file. E.g. borg, backInTime or simply rsync. Btw: Then this is not only a solution for KMyMoney but all other files, too.

The current backup system has some drawbacks, e.g. it works only if

  1. KMyMoney is running, and
  2. the user has to actively selects the backup option, and
  3. has to click a couple of times.

Both is not very user friendly (well we can discuss the first point).

Also I just think this is beyond the scope of KMyMoney. Does a user want KMyMoney to have such a function? Or is it better to have a single backup solution for all files (not only KMyMoney)? This request removes a couple hundred lines of codes which we do not need to maintain anymore.

P.S.: It never worked with databases.

I don't like this idea. In the moment there is no third part app to backup KMM, so there will be no backup feature at all.
Moreover I don't get why it must be third part app and not KMM.

Any backup software can be used because it is only needed to save a single file. E.g. borg, backInTime or simply rsync. Btw: Then this is not only a solution for KMyMoney but all other files, too.

The current backup system has some drawbacks, e.g. it works only if

  1. KMyMoney is running, and
  2. the user has to actively selects the backup option, and
  3. has to click a couple of times.

    Both is not very user friendly (well we can discuss the first point).

    Also I just think this is beyond the scope of KMyMoney. Does a user want KMyMoney to have such a function? Or is it better to have a single backup solution for all files (not only KMyMoney)? This request removes a couple hundred lines of codes which we do not need to maintain anymore.

    P.S.: It never worked with databases.

borg, backInTime or simply rsync seem pretty easy for administrator to do but I believe average user will struggle with:

  1. finding all files he needs to backup,
  2. restoring backup made in Linux on MS Windows,
  3. making backup on MS Windows where tools you mentioned may not exist or user may not know them.

I just think it isn't not going in user friendly direction. Let's wait for opinion of others.

I agree that this functionality should be maintained It might not be necessary if a user has an overall backup system set up, and I have thought about using git to maintain a full backup history (but would probably be more useful for the uncompressed xml file). While it may take a few mouse clicks, I think it is fewer than launching a separate program (which would need initial configuration) and the addition of the timestamp to the filename is extremely useful. Also, I do not use the "mount" option, but I can see it being useful to keep the backups on an external thumb drive for example. Perhaps it would be worth asking on the user list whether folks find it useful?

After I have just fixed the backup feature on master, I agree, that we should keep that feature. Some people rely on it to get a snapshot quickly.

wojnilowicz commandeered this revision.Sep 30 2017, 9:45 AM
wojnilowicz abandoned this revision.
wojnilowicz added a reviewer: christiand.