Differential D5631

Fix directory based search.
ClosedPublic
Actions

Authored by xuetianweng on Apr 28 2017, 8:54 AM.

Details

Reviewers
lbeltrame
Group Reviewers
Frameworks
Commits
R293:5f6bd28119c6: Fix directory based search.
Summary

canonicalPath() does not include the file name, but only the directory
name. Should use canonicalFilePath() instead.

Test Plan

Manually test with baloosearch

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xuetianweng created this revision.Apr 28 2017, 8:54 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 28 2017, 8:54 AM
lbeltrame added a subscriber: lbeltrame.Apr 28 2017, 10:11 AM

+1, I assume there are no tests for this functionality already present?

xuetianweng added a comment.Apr 28 2017, 7:58 PM

I saw there's filesearchstoretest.cpp in autotests/integration, but CMakeLists.txt doesn't build it. I guess this test might not work yet.

lbeltrame accepted this revision.Apr 29 2017, 6:53 AM

Looks fairly harmless to me. Perhaps wait one or two days more to see if anyone chimes in.

This revision is now accepted and ready to land.Apr 29 2017, 6:53 AM
elvisangelaccio added a subscriber: elvisangelaccio.Aug 9 2017, 9:32 PM

Any reason why this hasn't been committed yet?

Closed by commit R293:5f6bd28119c6: Fix directory based search. (authored by xuetianweng). · Explain WhyAug 9 2017, 9:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/searchstore.cpp (2 lines)

Diff 17950

View Options

src/lib/searchstore.cpp

Loading...