Differential D5503

No "KDE Daemon" in password dialogs
Needs ReviewPublic
Actions

Authored by lukas on Apr 19 2017, 11:03 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

Do not append non-translatable text "KDE Daemon" to the password dialog window title.

This is done automatically by the xcb QPA plugin here: https://code.woboq.org/qt5/qtbase/src/gui/kernel/qplatformwindow.cpp.html#_ZN15QPlatformWindow17formatWindowTitleERK7QStringS2_

Test Plan
  1. killall -9 kded
  2. Disconnect from the current AP
  3. Delete the network connection
  4. Try to reconnect, get the password dialog
  5. Observe the window title no longer getting the "KDE Daemon" string appended

Diff Detail

Repository
R297 KDED
Lint
Lint Skipped
Unit
Unit Tests Skipped
lukas created this revision.Apr 19 2017, 11:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 19 2017, 11:03 AM
lukas added a comment.Apr 19 2017, 11:08 AM

In action:

before
after

mck182 added a subscriber: mck182.Apr 19 2017, 2:57 PM

+1 looks good, although "Dialog hesla" je zvláštní češtin :)

apol added a subscriber: apol.Apr 19 2017, 3:08 PM

Maybe we want to have something else? Sometimes it's good to see where a dialog is coming from...

graesslin added a subscriber: graesslin.Apr 19 2017, 3:27 PM

not that "KDE Daemon" is a good name, but what about i18n it?

Revision Contents
Changeset List

PathPackages
Msrc/kded.cpp (1 line)

Diff 13589

View Options

src/kded.cpp

Loading...