Differential D5489

Sanitizers: Don't use GCC-like flags for e.g. MSVC
ClosedPublic
Actions

Authored by kfunk on Apr 18 2017, 7:07 AM.

Details

Reviewers
aacid
bcooksley
Commits
R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for e.g. MSVC
Summary

Fixes compiler warnings such as:

cl : Command line warning D9002 : ignoring unknown option
'-fsanitize=address'
cl : Command line warning D9002 : ignoring unknown option
'-fno-omit-frame-pointer'

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Apr 18 2017, 7:07 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptApr 18 2017, 7:07 AM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
aacid accepted this revision.Apr 18 2017, 9:23 AM

Makes sense, the other option would be actually erroring out as we do in check_compiler_version if you don't run "the correct clang/gcc", but i guess this may be enough for MSVC at this point.

This revision is now accepted and ready to land.Apr 18 2017, 9:23 AM
bcooksley accepted this revision.Apr 18 2017, 9:29 AM

Looks good to me - thanks for taking this on, it'll make getting CI working for Windows much easier.

Closed by commit R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for e.g. MSVC (authored by kfunk). · Explain WhyApr 21 2017, 4:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmodules/ECMEnableSanitizers.cmake (43 lines)

Diff 13679

View Options

modules/ECMEnableSanitizers.cmake

Loading...