Differential D5456

KDoctools: build on Mac with docbook from homebrew
ClosedPublic
Actions

Authored by winterz on Apr 14 2017, 10:49 PM.

Details

Reviewers
ltoscano
kfunk
Summary

On Mac, homebrew installs the docbook-xml and docbook-xls files under /usr/local/opt
so add searchpaths accordingly

Test Plan

builds on Mac now after running brew install docbook docbook-xsl

Diff Detail

Repository
R238 KDocTools
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Apr 14 2017, 10:49 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptApr 14 2017, 10:49 PM
Restricted Application added subscribers: Documentation, Frameworks. · View Herald Transcript
ltoscano edited edge metadata.Apr 14 2017, 10:57 PM

opt/docbook-xsl/ ? O.o
Well, not up to me to discuss that.
Just a question, no need for ${CMAKE_INSTALL_DATAROOTDIR}? I understand that it's a suffix, so not required, but if it was /opt, maybe it could be changed to ${CMAKE_INSTALL_DATAROOTDIR}/docbook etc etc

kfunk accepted this revision.Apr 15 2017, 4:52 PM
kfunk added a subscriber: kfunk.

I'd say: Add a comment that this is for OS X/homebrew then it's okay as-is.

This revision is now accepted and ready to land.Apr 15 2017, 4:52 PM
ltoscano added a comment.Apr 15 2017, 4:56 PM

if a comment should be added, then the review should not be accepted (yet)

kfunk added a comment.Apr 15 2017, 5:03 PM

It's a "fix it, then ship it" like acceptance.

winterz updated this revision to Diff 13520.EditedApr 16 2017, 6:51 PM

I added comments.

Also, I tried with different variations using ${CMAKE_INSTALL_DATAROOTDIR} and couldn't get it to work.

ltoscano accepted this revision.Apr 16 2017, 6:51 PM

Revision Contents
Changeset List

Diff 13520

View Options

cmake/FindDocBookXML4.cmake

Loading...
View Options

cmake/FindDocBookXSL.cmake

Loading...