Collect knowlegde found when investigating why i18n calls before line
QApplication app;
do not return translated strings.
Perhaps needs more prominent place to warn about the issues.
But having it documented somewhere will be a start.
ilic | |
aacid |
Frameworks |
Collect knowlegde found when investigating why i18n calls before line
QApplication app;
do not return translated strings.
Perhaps needs more prominent place to warn about the issues.
But having it documented somewhere will be a start.
No Linters Available |
No Unit Test Coverage |
Actually, I simplified/ignored how i18n calls internally make the gettext call chose a locale name for which a catalog has been found, by temporarily setting the LANGUAGE variable.
What do you think, should this implementation detail be noted here as well, or would it only result in confused readers, who might already being challenged a lot by the complexity how to use the ki18n API?
Looks a bit convoluted way of explaining not to use i18n before Q*Application, but i guess it works :)
I guess not bad to mention this stuff, but I would make following adaptations:
@ilic Thanks for the comments, agreed. Actually the initial text had some "really?" across it, as I was surprised about the findings stated in there and wanted (your) confirmation.
So made this info bit a subsection of the "Writing Messages" part, and changed it to first be handling instructions (given this is a guide), then have some explanation for the curious. Also dumped any proposals for custom usage of setlocale().
BTW, the <a name="x"> and \ref x seems not to work (only reused that for consistency), will do a separate patch later which follows instructions from http://doxygen.10944.n7.nabble.com/Creating-links-in-and-between-Markdown-files-pages-td6689.html
Hmpf, seems there is a bug in doxygen about section creation, as actually also stated by the doxygen author in the linked thread above. Guess that is also why currently the <a name="x"> are used. Giving up on that bug for now.
For the given patch in this review, will commit next WE unless someone has further comments :)(or before if you ilic give your okay)