| markg | |
| mck182 |
| VDG | |
| Plasma |
We've been having the configure button on notifications for a long time but so far it would only ever invoke KNotification configuration UI with no way for an application to provide its own, more versatile or extensive, UI.
When an action named "settings" is present in the notification the "configure" button will instead invoke this action.
Before:
Yes, this seems proprietary to Chrome which sends this along for its soon-to-be-released native notifications (above screenshot is from Chrome 59 with native notifications flag enabled) *but* I have wanted to have something like this for a long time and it's a good opportunity to introduce a de-facto standard for that now. I'll look into adding support for that in KNotifications, similar to the default action that was recently added.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Imho, it looks a lot better! Nice job!
Don't push it just yet though. Wait for the VDG to chime in.
While I like this, I wonder - for apps that will send "settings"
action there will now be no way to access the KNotification
settings, right (from the notification itself)? As in, the app can
use the "settings" action for an entirely different thing, thus
blocking the standard config UI, maybe?
if you use KNotifications you cannot influence the name of the action anyway, it's just Action %1