Ignore warnings during appdata generation
ClosedPublic

Authored by fvogt on Apr 7 2017, 9:05 AM.

Details

Summary

The Plasma/PopupApplet service type for example got deprecated and removed,
but is still used by various parts of Plasma 5.8.
This causes kpackagetool to emit warnings, but it still succeeds. However,
this case is handled incorrectly as any stderr output is assumed to be critical
and the file is not installed. As result is 0, no warning message is printed.

This commit fixes this by ignoring the stderr output and using result to indicate
success. Warning messages are printed if applicable.

Major issue is that kpackagetool5 does not exit with an error if it encounters
an error, so this installs a broken appdata file in some circumstances.

BUG: 378529

Test Plan

Built Plasma 5.8 with this patch. Works fine now.
As warnings are now printed, it uncovered some little issues as well.

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Apr 7 2017, 9:05 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 7 2017, 9:05 AM
mart accepted this revision.Apr 7 2017, 9:15 AM
This revision is now accepted and ready to land.Apr 7 2017, 9:15 AM
This revision was automatically updated to reflect the committed changes.