| aacid |
| Frameworks |
The DTD talks about <kpartgui> being deprecated as toplevel element,
so the data and tests should follow that.
Also fixes wrong DOCTYPE name usage, "gui" instead of "kpartgui"
makes no sense given there is only the one DTD
(will be separate commit).
To reduce confusion there either should be a new DTD
or the already existing kxmlgui.xsd schema and the respective
header should be promoted.
Tests still work, tested apps also.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Do you know where we do the parsing that allows both gui and kpartgui to be "valid"?
I did some searching and i think i found it but would be nice if you can find it and we agree on it D:
What I found is that the parsing does not check the name of the root element, so <gui>, <kpartgui> or the more ancient <kpartplugin> (which I came across e.g. in some rc files KDevPlatform) all work. Or whatever else one might use, like <mylittlegui> ;)
For code which does that, I think e.g. of KXMLGUIClient::setDOMDocument(), which just takes the doc.documentElement() of the passed DOM documents without any validation.
Eek, I just learned that changing the doctype name to "kpartgui" breaks the XML standard, which requires this:
"The Name in the document type declaration MUST match the element type of the root element." (cmp. https://www.w3.org/TR/xml11/#dt-doctype)
That info was missing/wrong in the comments in kpartgui.dtd which talk about the deprecated/non-deprecated root element.
Needs a fixup patch, will do tomorrow.