When quick tiling animate the outline from the window geometry to the position it would have afterwards.
This provides a visual hint to from where to where the window will go.
Details
Details
The outline window size is a union of target and destination size and the animation itself is done in QML, ie. no window position is animated.
Due to this, when the outline is already shown (e.g. dragging the window along a side of the screen) it jumps into new position without an animation like before.
Also, in order to facilitate the initial animation, it first calls show() on the outline and then sets active true after which QML will animate.
The non-composited outline is unchanged.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| geometry.cpp | ||
|---|---|---|
| 3257 | I'm not sure whether geometry() always provides the correct geometry you want to have. I think moveResizeGeometry() would be the better choice here. | |
Comment Actions
+1, I like the new animation.
It adds information without introducing any new "clutter" or slow down
Comment Actions
The movement clearly shows that the window will resize better than a strict fade. +1!
On a side note, and this may be a separate revision to consider later, but we may want to animate the transition as you move a window along the edge into different hot-spots. Right now there's no transition at all, and it may be good to use a transform effect similar to how we treat Plasma tooltips. But that may be for another revision, as this is a marked improvement on its own and gets my vote.