Alignment of audio clips and folders with other clips in project bin
Needs ReviewPublic

Authored by ashark on Mar 27 2017, 7:23 PM.

Details

Summary

I want to fix bug https://bugs.kde.org/show_bug.cgi?id=358173 (alignment of audio clips and folders).

As I see it, wrong alignment is happening because we just use generic icons for folders and audio clips, but we specially prepare thumbnails for image and video clips.

To fix this, I think we should somehow transfer generic icon to our "preparator" of thumbnails, so icon will become rectangle instead of square. And when we place them on their places, their width will be the same as another clips.

I have explored a bit, and found some related places in code:

bin.h:

void slotRefreshClipThumbnail(const QString &id);
void slotThumbnailReady(const QString &id, const QImage &img, bool fromFile = false);

abstractprojectitem.cpp:

QPixmap AbstractProjectItem::roundedPixmap(const QPixmap &source)

projectclip.cpp:

void ProjectClip::setThumbnail(const QImage &img)

projectsubclip.cpp:

void ProjectSubClip::setThumbnail(const QImage &img)

but I could not find exact place, where we send clip as a parameter to somewhat "thumbnailer" to extract an image from. These methods already get images as a parameter.

I tryed to make change of where we set audio thumbnail, but it did not helped.

I am beginner, so have no much experience, and will be glad if somebody of you will help me to study how to contribute with this.

Diff Detail

Repository
R158 Kdenlive
Lint
Lint Skipped
Unit
Unit Tests Skipped
ashark created this revision.Mar 27 2017, 7:23 PM
frdbr edited edge metadata.EditedMar 27 2017, 7:43 PM

Hi @ashark

Thanks for your interest in the project :)

We have a compiled a list of low hanging bugs in case you are interested in getting aquainted with the code base:

https://bugs.kde.org/buglist.cgi?quicksearch=product%3Akdenlive%20flag%3Alow_hanging&list_id=1430862

Cheers

@afarid Thanks for the link, I will make a review request for what I can fix myself.
By the way, what if changing is trivial and I just want to provide a patch without asking for review? For example, I recently did a "review request", but there is nothing to review there: https://git.reviewboard.kde.org/r/130008/ =)
As I can see, kdenlive team prefer phabricator, but not reviewboard, correct?

frdbr added a subscriber: alcinos.Mar 27 2017, 8:11 PM
In D5205#98127, @ashark wrote:

@afarid Thanks for the link, I will make a review request for what I can fix myself.
By the way, what if changing is trivial and I just want to provide a patch without asking for review? For example, I recently did a "review request", but there is nothing to review there: https://git.reviewboard.kde.org/r/130008/ =)
As I can see, kdenlive team prefer phabricator, but not reviewboard, correct?

I would always contact the mailing list when for doubts/questions/patches but lets wait for an answer from @alcinos, @vpinon or @mardelle who can inform you on the best practice for going about this.

Cheers

PS
Hope you get many of them low hanging bugs :)