Port away from KDELibs4Support
ClosedPublic

Authored by rthomsen on Mar 24 2017, 8:59 PM.

Details

Summary

Remove dependency on KDELibs4Support.

Test Plan

Everything works and looks normal in KInfoCenter

Diff Detail

Repository
R102 KInfoCenter
Lint
Lint Skipped
Unit
Unit Tests Skipped
rthomsen created this revision.Mar 24 2017, 8:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMar 24 2017, 8:59 PM
cfeck added a subscriber: cfeck.Mar 24 2017, 9:21 PM

Please add KCrash integration (which was done automatically for KApplication, but not for QApplication).

rthomsen updated this revision to Diff 12779.Mar 24 2017, 9:38 PM

Add KCrash integration.

cfeck added inline comments.Mar 24 2017, 9:52 PM
Modules/pci/kpci.cpp
96 ↗(On Diff #12777)

Check the indentation (tabs vs spaces?) Always view with a tabsize of 8 positions.

rthomsen updated this revision to Diff 12793.Mar 25 2017, 12:54 PM
  • Also port the libraw1394 module.
  • Fix tab indentation.
rthomsen edited the summary of this revision. (Show Details)Mar 25 2017, 12:55 PM
rthomsen marked an inline comment as done.
davidedmundson accepted this revision.Mar 29 2017, 9:54 AM
This revision is now accepted and ready to land.Mar 29 2017, 9:54 AM
This revision was automatically updated to reflect the committed changes.