Remove unused Qt::WindowFlags parameters from internal API
ClosedPublic

Authored by kossebau on Mar 23 2017, 9:15 PM.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 23 2017, 9:15 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 23 2017, 9:15 PM
kfunk accepted this revision.Mar 23 2017, 9:38 PM
kfunk added a subscriber: kfunk.

I know why you did that! ;)

This revision is now accepted and ready to land.Mar 23 2017, 9:38 PM
apol added a subscriber: apol.Mar 23 2017, 11:23 PM
In D5159#97239, @kfunk wrote:

I know why you did that! ;)

Now I want to know too.

+1 on the patch, thanks!

In D5159#97250, @apol wrote:
In D5159#97239, @kfunk wrote:

I know why you did that! ;)

Now I want to know too.

He watched me last summer ;)

Na, it's rather this: marking these code lines, which have flags = nullptr inside, as unused and thus removing them is a gentle solution to reduce the number of objects where Kevin and I have different ideas about, or, at least, where I currently got over-sensitive about when seeing such "logic" ;) For background see https://phabricator.kde.org/D3987#78257 ff.

+1 on the patch, thanks!

Thanks both for instant review.

This revision was automatically updated to reflect the committed changes.