Differential D5104

Error page, correctly load the image (with a real URL)
ClosedPublic
Actions

Authored by ltoscano on Mar 18 2017, 10:37 PM.

Details

Reviewers
mpyne
Commits
R313:ce81d9cbf23b: Error page, correctly load the image (with a real URL)
Summary

The local address to the image is injected into an HTML page (the
error page). This address needs to be a proper URL with file:///,
not just the absolute path to the image file - otherwise
KIO::SimpleJobPrivate::simpleJobInit complains with "Invalid URL".

Test Plan

Compiles, and when trying to load an invalid address in Konqueror
with the KHTML part, the warning picture on the top-left corner is
now visible.

Diff Detail

Repository
R313 KHtml
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Mar 18 2017, 10:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2017, 10:37 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mpyne added a subscriber: mpyne.Mar 19 2017, 3:43 PM

Will try to look later today but won't be able to at this point.

mpyne added a comment.Mar 20 2017, 3:11 AM

The patch looks fine to me, and gives a file:// that successfully opens in a separate Konq tab... but the image still doesn't show in the actual error page. I'm not sure of the cause though and have no time to research further tonight. :(

ltoscano added a comment.Mar 23 2017, 10:00 PM

Thanks for checking: with this patch you should not see the error that I reported in the summary/commit message. Is it the case? If it is, I guess that the patch can go in.
It's interesting to note that I have the same issue that you reported on one of my two machines; it works on the other. Same operating system, same configuration, same kdesrc-build O.o.

mpyne accepted this revision.Mar 30 2017, 1:46 AM
In D5104#97246, @ltoscano wrote:

Thanks for checking: with this patch you should not see the error that I reported in the summary/commit message. Is it the case? If it is, I guess that the patch can go in.
It's interesting to note that I have the same issue that you reported on one of my two machines; it works on the other. Same operating system, same configuration, same kdesrc-build O.o.

I didn't get the exact SimpleJob error message you noted, no. But I didn't remember to check before applying the patch either. Either way it makes it no worse, so +1.

This revision is now accepted and ready to land.Mar 30 2017, 1:46 AM
Closed by commit R313:ce81d9cbf23b: Error page, correctly load the image (with a real URL) (authored by ltoscano). · Explain WhyMar 30 2017, 7:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/khtml_part.cpp (2 lines)

Diff 13013

View Options

src/khtml_part.cpp

Loading...