Differential D5092

[KMessageWidget] Fix wrong size hint when animatedShow() is called with a hidden parentWidget()
ClosedPublic
Actions

Authored by cfeck on Mar 18 2017, 1:28 AM.

Details

Reviewers
elvisangelaccio
kossebau
Commits
R236:0cfb788c2e44: Fix wrong size hint when animatedShow is called with hidden parent
Summary

If the parent widget is not visible, then immediately show() the message widget to compute proper size hint. Otherwise, when the widget is later implicitely shown when parent gets visible, we are too late.

Fixes https://bugs.kde.org/show_bug.cgi?id=377676

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Mar 18 2017, 1:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2017, 1:28 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
elvisangelaccio accepted this revision.Mar 19 2017, 10:32 AM

I cannot reproduce that bug but the patch looks good to me.

This revision is now accepted and ready to land.Mar 19 2017, 10:32 AM
Closed by commit R236:0cfb788c2e44: Fix wrong size hint when animatedShow is called with hidden parent (authored by cfeck). · Explain WhyMar 28 2017, 12:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagewidget.cpp (3 lines)

Diff 12889

View Options

src/kmessagewidget.cpp

Loading...