boost include dirs
ClosedPublic

Authored by amccann on Nov 7 2015, 9:24 AM.

Details

Summary

boost headers not being found while compiling.

This fixed the problem for me.

I'm not that familiar with cmake, so I'm not sure if this is the best solution.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amccann updated this revision to Diff 1190.Nov 7 2015, 9:24 AM
amccann retitled this revision from to boost include dirs.
amccann updated this object.
amccann edited the test plan for this revision. (Show Details)
amccann added reviewers: mwolff, kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 7 2015, 9:24 AM
arichardson added inline comments.
language/CMakeLists.txt
19

I would use target_include_directories(KDevPlatformLanguage PRIVATE ${Boost_INCLUDE_DIRS}) after the add_library() call instead. That way the -I flag is only added to that target and not to all targets here

amccann updated this revision to Diff 1197.Nov 7 2015, 11:48 PM
  • Use arichardson's advice
amccann added inline comments.Nov 7 2015, 11:49 PM
language/CMakeLists.txt
19

This makes sense.

Only add these include paths to the specific target.

Did this, and I did verify that it compiles with this change.

arichardson accepted this revision.Nov 8 2015, 12:37 AM
arichardson added a reviewer: arichardson.
This revision is now accepted and ready to land.Nov 8 2015, 12:37 AM
This revision was automatically updated to reflect the committed changes.
amccann marked an inline comment as done.
mwolff edited edge metadata.Nov 12 2015, 11:55 AM
mwolff added a project: KDevelop.