make services GHNS work with store.kde.org
ClosedPublic

Authored by mart on Mar 13 2017, 3:48 PM.

Details

Summary

point the knsrc providers file to the new kde store,
and port the servicemenuinstallation/servicemenudeinstallation
scripts to kf5 (they still were based on kde4-config)
BUG:376922

Test Plan

downloaded some service menus (send to telegram, convert svg)
by the knewstuff ui available in the services page of config dialog
they get installed in the proper folder and work, uninstall works

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 13 2017, 3:48 PM
elvisangelaccio added inline comments.
src/settings/services/servicemenudeinstallation
5

qtpaths --paths GenericDataLocation is more future-proof.

src/settings/services/servicemenuinstallation
5

Same here.

mart edited the summary of this revision. (Show Details)Mar 14 2017, 9:54 AM
mart updated this revision to Diff 12458.Mar 14 2017, 10:00 AM
  • use qtpaths
src/settings/services/servicemenudeinstallation
5

Now we need a leading / before kservices5 ;)

emmanuelp added inline comments.Mar 14 2017, 10:52 AM
src/settings/services/servicemenudeinstallation
5

qtpaths --paths GenericDataLocation is more future-proof.

Maybe better: qtpaths --writable-path GenericDataLocation
This avoids the str splitting and is more deterministic because it doesn't rely on the ordering of the output.

src/settings/services/servicemenudeinstallation
5

Maybe better: qtpaths --writable-path GenericDataLocation
This avoids the str splitting and is more deterministic because it doesn't rely on the ordering of the output.

Yep, good point!

mart updated this revision to Diff 12460.Mar 14 2017, 11:03 AM
  • use writable location
emmanuelp accepted this revision.Mar 14 2017, 11:09 AM

Thanks!

This revision is now accepted and ready to land.Mar 14 2017, 11:09 AM
This revision was automatically updated to reflect the committed changes.