drop examples dir
ClosedPublic

Authored by sitter on Mar 13 2017, 10:36 AM.

Details

Summary
  • it does not build on its own (doesn't find_package anything)
  • it is not wired into the overall build (so you can't build it as part of that either)
  • it does not get installed (making it nigh impossible to find for 3rd party devs)
  • 2/2 kde devs did not even know this example exists
  • it contains a Messages.sh which is run and extracts and even gets translations (! what waste !)

to fix all of the above drop the entire directory. if someone wants to
bring it back, the above issue list should be dealt with. in particular
the Messages.sh problem (conceivably the extract line could be commented
out with a todo note that it needs enabling for i18n).

Diff Detail

Repository
R308 KRunner
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 13 2017, 10:36 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 13 2017, 10:36 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript

Couldn't it go to kdeexamples if interesting enough (or at least its frameworks branch, if any?)

Not interesting enough to me. If someone finds it interesting, sure.

broulik accepted this revision.Sep 27 2017, 8:42 AM
This revision is now accepted and ready to land.Sep 27 2017, 8:42 AM
This revision was automatically updated to reflect the committed changes.