[QDBusMenuBar] Connect to popupRequested signal
ClosedPublic

Authored by broulik on Mar 6 2017, 10:09 AM.

Details

Summary

This signal is emitted when an item should be activated, e.g. when pressing Alt+F to open the "File" menu.
It is looked up at runtime as distributions might have backported this feature from Qt 5.8.

CCBUG: 376726

Test Plan

Compiles. I don't have Qt 5.8 and nor do I have a backported patch. Please test.

(patch is for 5.9 branch)

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 6 2017, 10:09 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2017, 10:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt requested changes to this revision.Mar 6 2017, 10:17 AM

Can't apply to Plasma/5.9 with arc patch as your diff is missing the workaround code for Qt 5.7.0.

This revision now requires changes to proceed.Mar 6 2017, 10:17 AM
broulik updated this revision to Diff 12263.Mar 7 2017, 1:02 PM
broulik edited edge metadata.
  • Rebase to 5.9
broulik edited the summary of this revision. (Show Details)Mar 7 2017, 1:03 PM
fvogt accepted this revision.Mar 7 2017, 1:04 PM

Tested this with Qt 5.6.2 + backports, the signal gets triggered fine. So far it only seems to work with a few select apps (dolphin), some (e.g. konsole) do not assign shortcuts at all and others add shortcuts but assign them more than once...

This revision is now accepted and ready to land.Mar 7 2017, 1:04 PM
This revision was automatically updated to reflect the committed changes.