Differential D4873

Show pointing hand cursor when hovering spaceinfo bar
ClosedPublic
Actions

Authored by elvisangelaccio on Mar 1 2017, 4:55 PM.

Details

Reviewers
emmanuelp
gregormi
Commits
R318:e8eb6a7f2c27: Show pointing hand cursor when hovering spaceinfo bar
Summary

This improves the discoverability of the diskspace menu, a feature
otherwise almost impossible to find.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Mar 1 2017, 4:55 PM
elvisangelaccio added a comment.Mar 1 2017, 4:58 PM

Screenshot:

I'd say not a perfect solution because to discover the feature you still need to pass with the mouse over the widget, but at least it's better than the current situation.

emmanuelp requested changes to this revision.Mar 5 2017, 2:33 PM
emmanuelp added inline comments.
src/statusbar/statusbarspaceinfo.cpp
60

No need to override the enter event. Change the cursor in the ctor instead.

This revision now requires changes to proceed.Mar 5 2017, 2:33 PM
elvisangelaccio updated this revision to Diff 12187.Mar 5 2017, 2:51 PM
elvisangelaccio edited edge metadata.
  • Set cursor only once, in the constructor.
elvisangelaccio marked an inline comment as done.Mar 5 2017, 2:51 PM
emmanuelp accepted this revision.Mar 5 2017, 2:57 PM

Nice, thanks!

This revision is now accepted and ready to land.Mar 5 2017, 2:57 PM
Closed by commit R318:e8eb6a7f2c27: Show pointing hand cursor when hovering spaceinfo bar (authored by elvisangelaccio). · Explain WhyMar 10 2017, 6:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12370

View Options

src/statusbar/statusbarspaceinfo.cpp

Loading...