Show "portname (unavailable)" in port list if a port is not available.
BUG: 377193
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R115:3e497a1518ed: Indicate that a port is unavailable
R994:3e497a1518ed: Indicate that a port is unavailable
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Branch
- kcm-unavailable-ports (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Would it make sense to disable (in the ContextMenu) and/or filter out those ports instead? Or is this so you can configure it to play on headphones and once you plug them in it will work? Not sure about the "unavailable" prefix.
| src/kcm/package/contents/ui/DeviceListItem.qml | ||
|---|---|---|
| 84 ↗ | (On Diff #11931) | You could also just use a JS Array for this since you're not making use of ListModel's binding capabilities (you always clear and re-populate the model) |
| 91 ↗ | (On Diff #11931) | Better cache port as variable: var port = ports[i]; ... |
Comment Actions
Use same wording as pavucontrol - unavailable only for internal devices, unplugged otherwise
Comment Actions
Would it make sense to disable (in the ContextMenu) and/or filter out those ports instead? Or is this so you can configure it to play on headphones and once you plug them in it will work?
I don't think we should filter/disable it, because if you plug it in, it will play from this port.